Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/VM/Advanced): fix 'not enough permission' error for super admins when attaching PCIs #7793

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jul 1, 2024

Description

Can be tested on the pool 172.16.210.83 with the VM MRA PCI.
On the host XCP XO 8.3.0 slave 2, the PCI Non-Volatile memory controller is ready to be attached to a VM.
Feel free to migrate the VM's VDI if you need to fully test the fix.
If you move the VM's VDI on the XOSTOR NVME SR, don't start the VM otherwise the VM will not start

Fixes Forum#9260

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Copy link
Contributor

@MelissaFrncJrg MelissaFrncJrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VM start fails with the following error:

vm.start
{
  "id": "1b20c2ca-dc4e-717a-0940-7452b719a090",
  "bypassMacAddressesCheck": false,
  "force": false
}
{
  "code": "INTERNAL_ERROR",
  "params": [
    "xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\"))"
  ],
  "call": {
    "method": "VM.start",
    "params": [
      "OpaqueRef:0dc8626f-f85a-6164-7345-20b2d7597dd9",
      false,
      false
    ]
  },
  "message": "INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))",
  "name": "XapiError",
  "stack": "XapiError: INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))
    at Function.wrap (file:///home/mel/VATES/xen-orchestra/packages/xen-api/_XapiError.mjs:16:12)
    at file:///home/mel/VATES/xen-orchestra/packages/xen-api/transports/json-rpc.mjs:38:21
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:130:17)"
}

@MathieuRA
Copy link
Member Author

The VM start fails with the following error:

vm.start
{
  "id": "1b20c2ca-dc4e-717a-0940-7452b719a090",
  "bypassMacAddressesCheck": false,
  "force": false
}
{
  "code": "INTERNAL_ERROR",
  "params": [
    "xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\"))"
  ],
  "call": {
    "method": "VM.start",
    "params": [
      "OpaqueRef:0dc8626f-f85a-6164-7345-20b2d7597dd9",
      false,
      false
    ]
  },
  "message": "INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))",
  "name": "XapiError",
  "stack": "XapiError: INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))
    at Function.wrap (file:///home/mel/VATES/xen-orchestra/packages/xen-api/_XapiError.mjs:16:12)
    at file:///home/mel/VATES/xen-orchestra/packages/xen-api/transports/json-rpc.mjs:38:21
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:130:17)"
}

The VM fail to start because of an issue in the host. Not due to the PR

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias July 12, 2024 08:20
@MathieuRA MathieuRA requested a review from pdonias July 12, 2024 13:35
@pdonias pdonias changed the title fix(xo-web/VM/Advanced): fix 'not enought permission' error for super admins when attaching PCIs fix(xo-web/VM/Advanced): fix 'not enough permission' error for super admins when attaching PCIs Jul 16, 2024
@pdonias pdonias merged commit b539b5f into master Jul 16, 2024
1 check passed
@pdonias pdonias deleted the fix-attach-pci branch July 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants