-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-web/VM/Advanced): fix 'not enough permission' error for super admins when attaching PCIs #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… admins when attaching PCIs
MelissaFrncJrg
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VM start fails with the following error:
vm.start
{
"id": "1b20c2ca-dc4e-717a-0940-7452b719a090",
"bypassMacAddressesCheck": false,
"force": false
}
{
"code": "INTERNAL_ERROR",
"params": [
"xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\"))"
],
"call": {
"method": "VM.start",
"params": [
"OpaqueRef:0dc8626f-f85a-6164-7345-20b2d7597dd9",
false,
false
]
},
"message": "INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))",
"name": "XapiError",
"stack": "XapiError: INTERNAL_ERROR(xenopsd internal error: Cannot_add(0000:01:00.1, Xenctrlext.Unix_error(30, \"1: Operation not permitted\")))
at Function.wrap (file:///home/mel/VATES/xen-orchestra/packages/xen-api/_XapiError.mjs:16:12)
at file:///home/mel/VATES/xen-orchestra/packages/xen-api/transports/json-rpc.mjs:38:21
at runNextTicks (node:internal/process/task_queues:60:5)
at processImmediate (node:internal/timers:447:9)
at process.callbackTrampoline (node:internal/async_hooks:130:17)"
}
The VM fail to start because of an issue in the host. Not due to the PR |
pdonias
requested changes
Jul 12, 2024
pdonias
reviewed
Jul 12, 2024
pdonias
approved these changes
Jul 16, 2024
pdonias
changed the title
fix(xo-web/VM/Advanced): fix 'not enought permission' error for super admins when attaching PCIs
fix(xo-web/VM/Advanced): fix 'not enough permission' error for super admins when attaching PCIs
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can be tested on the pool
172.16.210.83
with the VMMRA PCI
.On the host
XCP XO 8.3.0 slave 2
, the PCINon-Volatile memory controller
is ready to be attached to a VM.Feel free to migrate the VM's VDI if you need to fully test the fix.
If you move the VM's VDI on the
XOSTOR NVME
SR, don't start the VM otherwise the VM will not startFixes Forum#9260
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md