Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backups): CBT omnibus #7792

Closed
wants to merge 13 commits into from
Closed

fix(backups): CBT omnibus #7792

wants to merge 13 commits into from

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jul 1, 2024 •
edited
Loading

Description

review by commits

Fix:

  • snapshot retention with full backups
  • off by one error for retention length
  • parent locator error
  • can't destructure undefined error
  • it don't leak vdi attached in the dom0 in our lab
  • progress is back on the export task

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp changed the title fix(backups): don't keep a snapshot for full backups fix(backups): CBT omnibus Jul 1, 2024
@fbeauchamp fbeauchamp marked this pull request as ready for review July 2, 2024 06:31
@fbeauchamp fbeauchamp requested a review from julien-f July 2, 2024 06:37
@fbeauchamp fbeauchamp mentioned this pull request Jul 2, 2024
Open
@fbeauchamp fbeauchamp force-pushed the fix_cbt branch 2 times, most recently from 33d26d7 to 7f7a65a Compare July 2, 2024 15:50
@fbeauchamp fbeauchamp requested a review from julien-f July 3, 2024 06:32
julien-f
julien-f reviewed Jul 3, 2024
View reviewed changes
@xen-orchestra/xapi/vdi.mjs Outdated
// call to list changed blocks must be done before the vdi is mounted for NBD export
try {
changedBlocks = await this.VDI_listChangedBlock(ref, baseRef)
baseParentUuid = await this.getField('VDI', baseRef, 'sm_config').then(sm_config => sm_config?.['vhd-parent'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
baseParentUuid = await this.getField('VDI', baseRef, 'sm_config').then(sm_config => sm_config?.['vhd-parent'])
baseParentUuid = await this.getField('VDI', baseRef, 'sm_config').then(sm_config => sm_config['vhd-parent'])

julien-f
julien-f reviewed Jul 3, 2024
View reviewed changes
@xen-orchestra/xapi/vdi.mjs Outdated
// call to list changed blocks must be done before the vdi is mounted for NBD export
try {
changedBlocks = await this.VDI_listChangedBlock(ref, baseRef)
baseParentUuid = await this.getField('VDI', baseRef, 'sm_config').then(sm_config => sm_config?.['vhd-parent'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle the case where it is undefined (no vhd-parent).

@fbeauchamp fbeauchamp marked this pull request as draft July 4, 2024 07:03
@fbeauchamp
Copy link
Collaborator Author

superseeded by #7805

@fbeauchamp fbeauchamp closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbeauchamp @julien-f