Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web,web-core,lite/i18n): add Persian #7775

Merged
merged 8 commits into from
Jul 9, 2024
Merged

feat(xo-web,web-core,lite/i18n): add Persian #7775

merged 8 commits into from
Jul 9, 2024

Conversation

Jokar-xen
Copy link
Contributor

Description

I added Persian translation for XO Lite.

@julien-f julien-f requested a review from OlivierFL June 26, 2024 13:52
OlivierFL
OlivierFL requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@OlivierFL OlivierFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Jokar-xen, thank you for your contribution! It is greatly appreciated.

I’ve added some comments on each file to ensure that the translations work correctly. Please feel free to comment and notify me if you have any questions or if something is unclear.

@xen-orchestra/lite/src/locales/fa.json Show resolved Hide resolved
packages/xo-web/src/common/intl/locales/fa.js Show resolved Hide resolved
@OlivierFL
Copy link
Collaborator

Hello @Jokar-xen, thank you for making the changes. We’re on the way to making a new release by the end of the week. New additions can’t be merged for now. However, rest assured that I will review your PR at the beginning of next week.

@Jokar-xen
Copy link
Contributor Author

Hello @Jokar-xen, thank you for making the changes. We’re on the way to making a new release by the end of the week. New additions can’t be merged for now. However, rest assured that I will review your PR at the beginning of next week.

Hi,
Thank you so much.

@OlivierFL OlivierFL requested a review from pdonias July 9, 2024 07:31
@pdonias pdonias changed the title Persian Translation feat(xo-web,web-core,lite/i18n): add Persian Jul 9, 2024
@pdonias pdonias merged commit 28f94b3 into vatesfr:master Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@OlivierFL OlivierFL OlivierFL approved these changes

Assignees
No one assigned
Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jokar-xen @OlivierFL @pdonias @olivierlambert