feat(core): creation of the useInteractiveTable composable #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierFL
requested changes
Jul 1, 2024
| @@ -80,7 +80,7 @@ const currentInteraction = computed(() => | |||
| interactions.value.find(interaction => router.currentRoute.value.query[columnName] === interaction.id) | |||
| ) | |||
|
|
|||
| const columnName = `${tableName}__${props.id}` | |||
| const columnName = stringifyColumnName(tableName, props.id) | |||
There was a problem hiding this comment.
To keep prop reactivity, this should be a computed:
Suggested change
| const columnName = stringifyColumnName(tableName, props.id) | |
| const columnName = computed(() => stringifyColumnName(tableName, props.id)) |
Comment on lines
+70
to
+71
| { id: 'sort-asc', icon: faArrowDown, label: t('core.sort.ascending') }, | ||
| { id: 'sort-desc', icon: faArrowUp, label: t('core.sort.descending') }, |
There was a problem hiding this comment.
Don't forget to remove the "coming soon" tooltip inside the template when the interaction is not disabled.
Comment on lines
+6
to
+14
| if (typeof prev === 'string' && typeof next === 'string') { | ||
| return prev.localeCompare(next) | ||
| } else if (typeof prev === 'number' && typeof next === 'number') { | ||
| return prev - next | ||
| } else if (prev instanceof Date && next instanceof Date) { | ||
| return prev.getTime() - next.getTime() | ||
| } else { | ||
| return String(prev).localeCompare(String(next)) | ||
| } |
There was a problem hiding this comment.
It comes down to personal preference and coding style, but what do you think of using this suggestion to improve readability?
Suggested change
| if (typeof prev === 'string' && typeof next === 'string') { | |
| return prev.localeCompare(next) | |
| } else if (typeof prev === 'number' && typeof next === 'number') { | |
| return prev - next | |
| } else if (prev instanceof Date && next instanceof Date) { | |
| return prev.getTime() - next.getTime() | |
| } else { | |
| return String(prev).localeCompare(String(next)) | |
| } | |
| if (typeof prev === 'string' && typeof next === 'string') { | |
| return prev.localeCompare(next) | |
| } | |
| if (typeof prev === 'number' && typeof next === 'number') { | |
| return prev - next | |
| } | |
| if (prev instanceof Date && next instanceof Date) { | |
| return prev.getTime() - next.getTime() | |
| } | |
| return String(prev).localeCompare(String(next)) |
|
Closed in favor of #7936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md