Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-6/header): make XO5 link work #7719

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(xo-6/header): make XO5 link work #7719

merged 1 commit into from
Jul 9, 2024

Conversation

OlivierFL
Copy link
Collaborator

Description

Introduced by b3ea140

Add a working link to XO5.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Jun 3, 2024
@OlivierFL OlivierFL requested a review from ByScripts June 3, 2024 15:14
ByScripts
ByScripts previously requested changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@ByScripts ByScripts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge then use #7681?

You'll can then merge.

@OlivierFL OlivierFL requested a review from MathieuRA July 9, 2024 07:32
@MathieuRA MathieuRA dismissed ByScripts’s stale review July 9, 2024 12:56

Comment resolved

@MathieuRA MathieuRA merged commit 4d42f86 into master Jul 9, 2024
1 check passed
@MathieuRA MathieuRA deleted the xo6/fix-xo5-link branch July 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

@ByScripts ByScripts ByScripts left review comments

Assignees

@OlivierFL OlivierFL

Labels
XO Web 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierFL @ByScripts @MathieuRA