refactor(backup/mirror): compute filter predicate only once

@xen-orchestra/backups/_runners/_vmRunners/FullRemote.mjs

@@ -8,8 +8,8 @@ export const FullRemote = class FullRemoteVmBackupRunner extends AbstractRemote
     return FullRemoteWriter
   }
 
-  _filterTransferlist(transferList) {
-    return transferList.filter(vmBackupMetadata => this._shouldTransferBackup(vmBackupMetadata))
+  _filterTransferList(transferList) {
+    return transferList.filter(this._filterPredicate)
   }
 
   async _run() {

@xen-orchestra/backups/_runners/_vmRunners/IncrementalRemote.mjs

@@ -18,8 +18,8 @@ class IncrementalRemoteVmBackupRunner extends AbstractRemote {
 
   // we'll transfer the full list if at least one backup should be transfered
   // to ensure we don't cut the delta chain
-  _filterTransferlist(transferList) {
-    if (transferList.some(vmBackupMetadata => this._shouldTransferBackup(vmBackupMetadata))) {
+  _filterTransferList(transferList) {
+    if (transferList.some(vmBackupMetadata => this._filterPredicate(vmBackupMetadata))) {
       return transferList
     }
     return []

@xen-orchestra/backups/_runners/_vmRunners/_AbstractRemote.mjs

@@ -12,6 +12,7 @@ import { extractIdsFromSimplePattern } from '../../extractIdsFromSimplePattern.m
 import { Task } from '../../Task.mjs'
 
 export const AbstractRemote = class AbstractRemoteVmBackupRunner extends Abstract {
+  _filterPredicate
   constructor({
     config,
     job,
@@ -60,6 +61,12 @@ export const AbstractRemote = class AbstractRemoteVmBackupRunner extends Abstrac
         })
       )
     })
+    const { filter } = job
+    if (filter === undefined) {
+      this._filterPredicate = () => true
+    } else {
+      this._filterPredicate = createPredicate(filter)
+    }
   }
 
   async #computeTransferListPerJob(sourceBackups, remotesBackups) {
@@ -124,21 +131,6 @@ export const AbstractRemote = class AbstractRemoteVmBackupRunner extends Abstrac
     return transferByJobs.flat(1)
   }
 
-  /**
-   * check if users want to mirror this vm backup
-   *
-   * @param {Object} vmBackupMetadata
-   * @returns Boolean
-   */
-  _shouldTransferBackup(vmBackupMetadata) {
-    const { filter } = this.job
-    if (filter === undefined) {
-      return true
-    }
-    const predicate = createPredicate(filter)
-    return predicate(vmBackupMetadata)
-  }
-
   async run($defer) {
     const handler = this._sourceRemoteAdapter._handler
     await Disposable.use(await handler.lock(getVmBackupDir(this._vmUuid)), async () => {