update #1
Open
update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard paths of AOSPlusone. You may want to change it accordingly to your rom.
We could fix them... or we could silence them, since it compiles and works just fine this way. J/K, we should really fix them. But in the meanwhile, let it compile. Signed-off-by: freshgiammi <[email protected]>
Fixes Clang complaining about syntax (-Wgnu-designator) Signed-off-by: freshgiammi <[email protected]>
Signed-off-by: freshgiammi <[email protected]>
See if this makes any difference, even if we fixed the errors. Signed-off-by: freshgiammi <[email protected]>
- mBufferCount is an unsigned int - Typecast to uint32_t to allow comparing it with index which is an int
Issue: Total number of ints in native handle is unknown to the video framework because of defining common ints locally within camera header. This is causing issue in batch mode recording usecase. Fix: Set VIDEO_METADATA_NUM_COMMON_INTS in a shared header between camera and video subsystems. CRs-Fixed: 1056156 Change-Id: I593f08debfea3db7070273a72d774c7fb963c4ca
Waits for sensorservice initialization before opening the actual HAL. Moved to OSS HAL from CameraWrapper. Originally by Danny Baumann <[email protected]>. Change-Id: I876d2f0a57e17da392d451987047189b05a5e72b
Change-Id: Iafc067c878daad27e3fb0c032ffb12b74b4d29ac Signed-off-by: Kshitij Gupta <[email protected]>
Change-Id: I47293ac0299aca81d9ab0abf48504a2aa1345de5 Signed-off-by: Kshitij Gupta <[email protected]>
- We aren't syncing the CAF Display HAL, so why even bother? Change-Id: I4e813b40bc58967c279e93387c395b10db0fedd2 Signed-off-by: Kshitij Gupta <[email protected]>
Signed-off-by: Kshitij Gupta <[email protected]>
Signed-off-by: Kshitij Gupta <[email protected]>
- Seems to throw a ton of errors - HAL builds fine without it Signed-off-by: Kshitij Gupta <[email protected]>
- Our HAL needs this on Oreo - Backport this change to our HAL Signed-off-by: Kshitij Gupta <[email protected]>
Signed-off-by: Kshitij Gupta <[email protected]>
In Android O, Cameraprovider service is introduced newly and its starting before main service which results in getnumofcameras failure. Added re-try count to fix this issue. Change-Id: I3a3ee1cbe6ad983d5ad7266f154b33b93d303804 Signed-off-by: Kshitij Gupta <[email protected]>
* Remove re declaration. * Define i as int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.