This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Open
Conversation
Non-C VSM readers need to be able to discover the default workdir. This introduces a new `-x workdir` argument to do just that.
Contributor
|
To me it feels wrong to launch varnishd for this, and I think it would much more sense to let varnishadm grow a "-x workdir" option ? |
Member
Author
|
I'll draft this PR and come back with a change in |
This reverts commit 410c1eb.
Non-C VSM readers need to be able to discover the default workdir. This introduces a new `-x workdir` argument to do just that. Co-authored-by: GitHub Copilot <copilot@github.com>
Member
Author
|
reverted the first commit to avoid force-pushing, so 1bc39af is the meat of it Just to stir the pot, I did ask copilot to write the code as a test and it's in the commit message for transparency, but the bag of mostly water here has reviewed and heavily edited what was produced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-C VSM readers need to be able to discover the default workdir. This introduces a new
-x workdirargument to do just that.