Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hardware decoding for AV1 #17

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Enable hardware decoding for AV1 #17

merged 1 commit into from
Jul 2, 2023

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Jul 2, 2023

No description provided.

@myrsloik
Copy link
Member

myrsloik commented Jul 2, 2023

This one looks weird. Why AV1 need special casing here and no other HW decoder? And why does the standard lookup fail?

@HolyWu
Copy link
Contributor Author

HolyWu commented Jul 2, 2023

Because external AV1 decoding library like libdav1d is software decoding only and cannot be used for hardware decoding. On the other hand, the av1 decoder is (currently) hardware decoding only and cannot be used for software decoding. We must explicitly find the av1 decoder here for hardware decoding, otherwise the other external decoders with higher priority will get picked by avcodec_find_decoder because the av1 decoder was set to the lowest priority. See FFmpeg/FFmpeg@47be5a5.

@myrsloik myrsloik merged commit 81ab759 into vapoursynth:master Jul 2, 2023
3 of 4 checks passed
@HolyWu HolyWu deleted the patch/av1_hw_decode branch July 2, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HolyWu @myrsloik