V5 #141
Open
V5 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix benchmarks take two * Add throughput thresholds * Wip
* First attempt at Swift 6 router * Make router immutable in benchmarks * Update benchmarks manifest * Re-add swift settings * Make options immutable * Update thresholds * Update thresholds * Update benchmarks * Adjust thresholds * Adjust thresholds * Use appropriate property * Create RouterBuilder * Update benchmarks * Address review and sprinke some `@inlinable` * Add back package setting * Update benchmarks * Update benchmark thresholds * Adjust threshold
* Implement partial matching * Attempt at making it fast * Cleanup * Undo * Partial Matching 2 (#143) * Different approach to partial matching * Nits * Avoid a copy * Minor improvements * Nit * Update Sources/RoutingKit/PathComponent.swift Co-authored-by: Gwynne Raskind <[email protected]> * Update Sources/RoutingKit/TrieRouter/TrieRouterNode.swift Co-authored-by: Gwynne Raskind <[email protected]> * Nits * Nit --------- Co-authored-by: Gwynne Raskind <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 83.91% 88.33% +4.42%
==========================================
Files 4 5 +1
Lines 230 240 +10
==========================================
+ Hits 193 212 +19
+ Misses 37 28 -9
🚀 New features to boost your workflow:
|
0xTim
requested changes
Oct 30, 2025
| @usableFromInline typealias Node = TrieRouterNode<Output> | ||
|
|
||
| /// Available ``TrieRouter`` customization options. | ||
| public enum ConfigurationOption: Sendable { |
Member
There was a problem hiding this comment.
Should we have a full configuration type instead? That would allow us to make this a Bool so we can avoid the enum for future configuration options
Member
There was a problem hiding this comment.
How much has this changed from the original router?
|
|
||
| @Test func testPartial() throws { | ||
| var routerBuilder = TrieRouterBuilder<Int>() | ||
| routerBuilder.register(42, at: ["test", ":{my-file}.json"]) |
Member
There was a problem hiding this comment.
Let's add some more tests to test things like a partial parameter only at the start, only at the end, failures for unclosed parameters etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.