-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: task search fields #1441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbritense
commented
Jun 24, 2024
#112765 - Create a way to store task search fields * Fixed tests for Windows.
…r tasks (#1434) Implement an endpoint that uses the task search field values to filter tasks
Changed the SearchFieldV2's so that the ownerType is now determined by subclass of the DTO to reduce the chance of issues by using wrong values for this field..
…hat was discovered while writing the test. (#1442) Added an extra test to test full task filter flow. Also fixed a bug that was discovered while writing the test.
…cessed by the right roles. (#1443)
…task-list-filter Merge/next minor into task list filter
…task-list-filter Merge/next minor into task list filter
…search-incorrect-count Fixed incorrect task count when filtering + added test proving it works
Added auto deployment for task search fields, set up so other search fields can easily be made auto deployable too.
…r-into-task-list-filter
…task-list-filter Merge next-minor into feature/task-list-filter
mbritense
changed the title
WIP: feature: task search fields
feature: task search fields
Jul 18, 2024
theo-ritense
previously approved these changes
Jul 18, 2024
mbritense
commented
Jul 18, 2024
"key": "achternaam", | ||
"path": "doc:achternaam", | ||
"dataType": "TEXT", | ||
"fieldType": "TEXT_CONTAINS", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed
marijnritense
approved these changes
Jul 18, 2024
theo-ritense
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.