Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steamdeck / path fixes #7

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Steamdeck / path fixes #7

wants to merge 11 commits into from

Conversation

djedu
Copy link

@djedu djedu commented Feb 19, 2024

Hi Valters!

I have made some changes to make your patcher compatible with my steamdeck. I encountered 2 issues:

  • Neither the linux shell commands or the windows process could access the '!Linux' directory (renamed)
  • My game is installed on an external sd card (E:\ drive in wine, not Z:)

I added a method to automatically detect the absolute linux path at the beginning of the Utils.dll, as this is the only way I could think of making this completely universal.
The method runs the following:

  • Finds the linux steam installation path
  • Checks the libraryfolders.vdf file in that path for available steam libraries
  • Scans the available libraries for the DayZ directory
  • Appends the absolute path in the ToUnixPath function

That way if the game is installed in Z:$HOME.steam etc. the function remains the same but if game is installed in E:\steamapps... we can still translate it to a Z: (root) path.

Tested on my steamdeck with over 1300 mods and works a treat.
I'm not great with C# so there's probably a way more efficient way of doing this! Any help would be appreciated!

Thanks,
Ed

@valters-tomsons
Copy link
Owner

valters-tomsons commented Mar 3, 2024

Huge thanks for the PR! 🌟

Your ideas are great, but I cannot merge it in current state. I'm looking to keep things lean and maintainable. To be more specific:

  • bash script logic should be moved into the patcher
  • code inside Utils is a little difficult to follow

I'm happy to adapt your ideas to fit my taste more closely, please confirm that's okay with you. Your contributions will be credited.

Thanks for being patient, and I hope my feedback doesn't discourage you. Your work is incredibly valuable.


That being said, this patcher may no longer be needed in the future. There is work happening in Mono to support reparse points. I also saw developers mention that they're planning to simplify the mod installation specifically for Proton.

@djedu
Copy link
Author

djedu commented Mar 28, 2024

Hi!

Absolutely! Not my forte so please feel free to re-write any of the ideas/fixes proposed!

I did struggle to find a suitable way of detecting linux paths without it running on every call without restructuring from the ground up, so not as clean as I would of liked..

I have personally moved to using some 3rd party launchers (DayZ Py Launcher & dzgui) as performance of the vanilla launcher with the amount of mods I have subscribed was quite bad. Hopefully they’ll rewrite it soon!

If there is anything I can assist with please do let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants