Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prevents potential crashes and unsafe decoding results when encountering invalid or malicious CBOR inputs. Specifically:
nil
silently, instead of throwing a meaningful error.These issues can lead to application crashes or unexpected behavior in production.
Changes
readLength()
, defaulting to 200,000 elements.CBORError.tooLongSequence
if the declared array or map length exceeds this limit.default
case indecodeItem()
to always throwCBORError.unfinishedSequence
for unknown or malformed input.nil
return from decoding, ensuring consistent error behavior on corrupt data.Rationale
Testing
CBORError.tooLongSequence
when encountering absurd array or map sizes.CBORError.unfinishedSequence
.Notes
Linked Issues