Skip to content

[DEFLAKE] Psync established after rdb load - beyond grace period #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
+1 −1
Open

[DEFLAKE] Psync established after rdb load - beyond grace period #2748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3406eca
increase the check for 6 seconds
roshkhatri Oct 17, 2025
8d7ddb9
Update tests/integration/dual-channel-replication.tcl
roshkhatri Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/dual-channel-replication.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ start_server {tags {"dual-channel-replication external:skip"}} {
# 4. Primary resumes operation and detects closed RDB channel.
# Expected outcome: Primary drops the RDB channel after grace period is done.
$replica replicaof $primary_host $primary_port
wait_for_log_messages 0 {"*Done loading RDB*"} $loglines 2000 1
wait_for_log_messages 0 {"*Done loading RDB*"} $loglines 2000 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax of this is proc is

proc wait_for_log_messages {srv_idx patterns from_line maxtries delay}

Reading the file every 5 milliseconds and repeating 2000 times seems like a quite heavy operation. Can we change these to a delay of 100 or 50 like in other wait-for expressions?

Suggested change
wait_for_log_messages 0 {"*Done loading RDB*"} $loglines 2000 5
wait_for_log_messages 0 {"*Done loading RDB*"} $loglines 100 100

Copy link
Member Author

@roshkhatri roshkhatri Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can so 100 100 and I dont think there should be an issue, we could do the same with the previous test Psync established after rdb load - within grace period

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see there are multiple (seven?) with 2000 1 in test suite, one with 4000 1, one with 20000 1 and eight(?) with 1000 10.

Let's change them all to use a delay of 100 while keeping the same total time?

pause_process $replica_pid
wait_and_resume_process -1
wait_for_condition 50 100 {
Expand Down
Loading