Remove TLSCONN_DEBUG dead code in tls.c #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WelongZuo
force-pushed
the
fix_undefined_var_in_tlsHandleEvent
branch
2 times, most recently
from
d91ba50 to
eb9f06b
Compare
|
Can you explain how this is triggered? Does it only happen in debug mode? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1891 +/- ##
============================================
+ Coverage 71.00% 71.01% +0.01%
============================================
Files 123 123
Lines 65671 65673 +2
============================================
+ Hits 46631 46639 +8
+ Misses 19040 19034 -6
🚀 New features to boost your workflow:
|
I haven't trigger this bug in production enviroment. Just find it when i learn the code. |
zuiderkwast
reviewed
Mar 27, 2025
Signed-off-by: WelongZuo <[email protected]>
WelongZuo
force-pushed
the
fix_undefined_var_in_tlsHandleEvent
branch
from
eb9f06b to
16de41b
Compare
enjoy-binbin
changed the title
enjoy-binbin
approved these changes
Mar 29, 2025
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Mar 31, 2025
This code is a dead code, there is also a undefined fd error in it. Obviously this will not compile if this kind of debugging is enabled. This seems to be broken ever since 5a47794 which was done in 2019. It's dead code that we never test and never use. Fixes valkey-io#1887 Signed-off-by: WelongZuo <[email protected]> Co-authored-by: z00636558 <[email protected]>
ranshid
pushed a commit
that referenced
this pull request
Mar 31, 2025
This code is a dead code, there is also a undefined fd error in it. Obviously this will not compile if this kind of debugging is enabled. This seems to be broken ever since 5a47794 which was done in 2019. It's dead code that we never test and never use. Fixes #1887 Signed-off-by: WelongZuo <[email protected]> Co-authored-by: z00636558 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is a dead code, there is also a undefined fd error in it.
Obviously this will not compile if this kind of debugging is enabled.
This seems to be broken ever since 5a47794
which was done in 2019. It's dead code that we never test and never use.
Fixes #1887