Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing issue in pause test #1631

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

madolson
Copy link
Member

The wait might execute exactly in 1000ms, which means there are still 9000ms left of the timeout, so we need to do less than or equal to in the comparison.

https://github.com/valkey-io/valkey/actions/runs/13000845302/job/36259020129

Signed-off-by: Madelyn Olson <[email protected]>
@madolson madolson requested a review from soloestoy January 28, 2025 08:03
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.95%. Comparing base (e9b8970) to head (24629c4).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1631      +/-   ##
============================================
- Coverage     71.04%   70.95%   -0.10%     
============================================
  Files           121      121              
  Lines         65174    65174              
============================================
- Hits          46304    46241      -63     
- Misses        18870    18933      +63     

see 15 files with indirect coverage changes

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, one millisecond.

@madolson madolson merged commit f695c52 into valkey-io:unstable Jan 28, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants