Skip to content

Conversation

@adam-fowler
Copy link
Collaborator

Also convert all command tests to use testCommandEncodesDecodes

Signed-off-by: Adam Fowler <[email protected]>
Signed-off-by: Adam Fowler <[email protected]>
Signed-off-by: Adam Fowler <[email protected]>
Add tests for HSCAN, ZSCAN and BLPOP

Signed-off-by: Adam Fowler <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

❌ Pull request has performance regressions ❌

Summary
================================================================================
Threshold deviations for ValkeyBenchmarks:Connection: GET benchmark – NoOpTracer
================================================================================
Malloc (total) (#, %) main pull_request Difference % Threshold %
p50 8375 9975 19 5

New baseline 'pull_request' is WORSE than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host 'f26e441e02d6' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 82 84 84 87 87 87 87 6
pull_request 84 84 86 87 88 88 88 6
Δ 2 0 2 0 1 1 1 0
Improvement % -2 0 -2 0 -1 -1 -1 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 95 99 103 106 108 110 110 24
pull_request 97 102 104 107 110 118 118 24
Δ 2 3 1 1 2 8 8 0
Improvement % -2 -3 -1 -1 -2 -7 -7 0

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 8
pull_request 4 4 4 4 4 4 4 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7 8 8 10 10 10 10 8
pull_request 7 8 10 10 10 10 10 7
Δ 0 0 2 0 0 0 0 -1
Improvement % 0 0 -25 0 0 0 0 -1

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 33 33 33 34 34 34 34 6
pull_request 33 33 34 34 34 34 34 6
Δ 0 0 1 0 0 0 0 0
Improvement % 0 0 -3 0 0 0 0 0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 33 33 33 34 34 34 34 5
pull_request 33 33 33 34 34 34 34 5
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 18
pull_request 0 0 0 0 0 0 0 19
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 738
pull_request 0 0 0 0 0 0 0 742
Δ 0 0 0 0 0 0 0 4
Improvement % 0 0 0 0 0 0 0 4

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1880
pull_request 0 0 0 0 0 0 0 1889
Δ 0 0 0 0 0 0 0 9
Improvement % 0 0 0 0 0 0 0 9

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 360
pull_request 0 0 0 0 0 0 0 357
Δ 0 0 0 0 0 0 0 -3
Improvement % 0 0 0 0 0 0 0 -3

@adam-fowler adam-fowler merged commit a789f2c into main Oct 17, 2025
11 of 13 checks passed
@adam-fowler adam-fowler deleted the zscan-hscan branch October 17, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant