Skip to content

Conversation

@hpatro
Copy link
Contributor

@hpatro hpatro commented Oct 13, 2025

Description

Adds content for "1 Billion RPS blog post"

Issues Resolved

#337

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@hpatro hpatro self-assigned this Oct 13, 2025
Signed-off-by: Kyle J. Davis <[email protected]>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all good blog post. I made a bunch of small edits in a pull request on to your fork @hpatro see: hpatro#1

One thing that needs cleaning up is a collection pronoun issue - there are uses of 'we'/'our' that I think are referring to the project but others that are referring to the group of authors. This needs to be super crisp - take a look through and determine who did what and revise. If it's the project, try to make a cleaner attribution.


## Closing thoughts

With all these improvements made in Valkey, a cluster can now scale to 1B RPS / 2000 nodes which is quite a remarkable feat to achieve. However, there is plenty of room to improve further. The steady state CPU utilization overhead from the cluster bus message transfer/processing can be reduced further by incorporating [SWIM protocol](https://en.wikipedia.org/wiki/SWIM_Protocol) or move it off the main thread into an independent separate thread. The failover logic can be made smarter as well by incorporating the AZ placement of nodes. We would also like to introduce more observability metrics/logs into the system for better manageability of it. All of these are being linked under [Support Large Cluster](https://github.com/valkey-io/valkey/issues/2281) issue. Feel free to check it out and add in your suggestions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a little better call to action. What can a user do next aside from look at the issue? Is there further reading? Another blog post of interest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engaging on the issue should be the next step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Feel free to check it out and add in your suggestions." - This statement was my call to action.

There is a detailed spec available here https://valkey.io/topics/cluster-spec/. Do we want to link it here ?

github: cherukum-Amazon
---

Mahesh Cherukumilli is an engineering leader passionate about large-scale distributed systems and high-performance databases. He sets strategy and builds high-performing teams that align architecture with business outcomes and deliver reliable, at-scale infrastructure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'large-scale distributed systems' appears in all three bios. Can we mix it up a bit? Or maybe you all just share a very similar passion? 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something quite difficult to update 😂

Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at the technical details and they looked good, will leave it to Kyle to ship.

hpatro and others added 5 commits October 14, 2025 14:48
review pass on 1 billion RPS blog
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
@hpatro
Copy link
Contributor Author

hpatro commented Oct 14, 2025

Over all good blog post. I made a bunch of small edits in a pull request on to your fork @hpatro see: hpatro#1

Thanks @stockholmux for the help, pulled that in.

One thing that needs cleaning up is a collection pronoun issue - there are uses of 'we'/'our' that I think are referring to the project but others that are referring to the group of authors. This needs to be super crisp - take a look through and determine who did what and revise. If it's the project, try to make a cleaner attribution.

Cleaned up the our and some usage of we. Left the usage of we in the benchmarking section to indicate the authors setup/work.

Please take a look.

@hpatro hpatro requested a review from stockholmux October 14, 2025 22:19
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
Signed-off-by: Harkrishn Patro <[email protected]>
@hpatro hpatro requested a review from makubo-aws October 15, 2025 17:53
@hpatro
Copy link
Contributor Author

hpatro commented Oct 15, 2025

@stockholmux / @makubo-aws please have a look, addressed your feedback.

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes and I'm clear to publish on Monday ahead of the 9.0 launch.

Signed-off-by: Harkrishn Patro <[email protected]>
@hpatro
Copy link
Contributor Author

hpatro commented Oct 15, 2025

Two small changes and I'm clear to publish on Monday ahead of the 9.0 launch.

Have addressed them. The folder name and the release date on the post is also set for 10/20. So, we are good to release on Monday. @stockholmux Thanks for the help!

@hpatro hpatro requested a review from stockholmux October 15, 2025 21:09
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stockholmux stockholmux merged commit 063c3be into valkey-io:main Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants