Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge to main] Support transactions for JSON commands #2862

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Merge to main] Support transactions for JSON commands #2862

wants to merge 11 commits into from

Conversation

yipin-chen
Copy link
Collaborator

@yipin-chen yipin-chen commented Dec 24, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2683

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

avifenesh and others added 6 commits December 23, 2024 22:11
@avifenesh @jhpung @yipin-chen
Node allow uncovered slots cscan (#2815)
c487df7 
* addresed comments

Signed-off-by: avifenesh <[email protected]>

* Go: add allow_non_covered_slots to ClusterScan and related commands

Signed-off-by: avifenesh <[email protected]>

* feat: Implement continuous slot scanning until next unscanned slot

Signed-off-by: jhpung <[email protected]>

* fix: improve slot scanning logic when address not found

Signed-off-by: jhpung <[email protected]>

* add allowNonCoveredSlots option to ScanOptions and update GlideClusterClient

Signed-off-by: avifenesh <[email protected]>

* test: add tests for GlideClusterClient scan with allowNonCoveredSlots option

Signed-off-by: avifenesh <[email protected]>

* refactor: enhance cluster readiness check and improve error handling in scan tests

Signed-off-by: avifenesh <[email protected]>

---------

Signed-off-by: avifenesh <[email protected]>
Signed-off-by: jhpung <[email protected]>
Co-authored-by: jhpung <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
@Yury-Fridlyand @yipin-chen
Update cluster_manager script (#2353)
f56e881 
* update script

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
@tjzhang-BQ @yipin-chen
Go: Add ZPopMin and ZPopMax (#2850)
b815a95 
* Go: Add ZPopMin and ZPopMax

Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
@prateek-kumar-improving @acarbonetto
@jonathanl-bq @yipin-chen
Node: transaction commands for json module (#2690)
4cc16c6 
* Node: Add Transaction for JSON commands

---------

Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Jonathan Louie <[email protected]>
@yipin-chen
Python: JSON commands in transaction (#2684)
2124f3e 
* Add support for JSON commands in transaction
---------

Signed-off-by: Yi-Pin Chen <[email protected]>
@jamesx-improving @yipin-chen
Java: JSON commands in transaction (#2691)
c82ce97 
* Java: add transaction commands for json module

---------

Signed-off-by: James Xin <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen force-pushed the merge/yipin-module-transactions branch from 64a5c94 to c82ce97 Compare December 24, 2024 06:20
@yipin-chen
Fix missing comma
8cad215 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen marked this pull request as ready for review December 24, 2024 20:30
@yipin-chen yipin-chen requested a review from a team as a code owner December 24, 2024 20:30
@yipin-chen yipin-chen changed the title Support transactions for JSON commands [Merge to main] Support transactions for JSON commands Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesx-improving jamesx-improving Awaiting requested review from jamesx-improving

@prateek-kumar-improving prateek-kumar-improving Awaiting requested review from prateek-kumar-improving

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yipin-chen @avifenesh @Yury-Fridlyand @tjzhang-BQ @prateek-kumar-improving @jamesx-improving