Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GO: Add BZPopMin command #2849

Merged
merged 10 commits into from
Jan 6, 2025
Merged

GO: Add BZPopMin command #2849

merged 10 commits into from
Jan 6, 2025

Conversation

jbrinkman
Copy link
Collaborator

@jbrinkman jbrinkman commented Dec 20, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (#2833)

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@yipin-chen yipin-chen mentioned this pull request Dec 20, 2024
Open
8 tasks
@jbrinkman jbrinkman force-pushed the go/jbrinkman-bzpopmin branch from 81f6eb5 to c7864d3 Compare December 23, 2024 21:13
@jbrinkman jbrinkman force-pushed the go/jbrinkman-bzpopmin branch 3 times, most recently from d6f02e2 to 22e8992 Compare December 24, 2024 20:50
@jbrinkman jbrinkman force-pushed the go/jbrinkman-bzpopmin branch from 51d0ed3 to efb2d08 Compare December 24, 2024 22:47
@jbrinkman jbrinkman marked this pull request as ready for review December 24, 2024 22:49
@jbrinkman jbrinkman requested a review from a team as a code owner December 24, 2024 22:49
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Dec 25, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 25, 2024
View reviewed changes
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
@jbrinkman jbrinkman force-pushed the go/jbrinkman-bzpopmin branch from 0704774 to 7564c80 Compare January 6, 2025 14:57
jbrinkman and others added 9 commits January 6, 2025 10:02
@jbrinkman
GO: Add BZPopMin command
259eb61 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add response handler for BZPopMin
a724aca 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
cleanup response handler for BZPopMin
64d2d2b 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add documentation for BZPopMin
8fbabda 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
update changelog for BZPopMin
723f46e 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/sorted_set_commands.go
ec2a3c0 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @prateek-kumar-improving
Update go/api/response_handlers.go
cf34941 
Co-authored-by: prateek-kumar-improving <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/sorted_set_commands.go
5caa255 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/sorted_set_commands.go
55648a7 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman jbrinkman force-pushed the go/jbrinkman-bzpopmin branch from 7564c80 to 1f10da5 Compare January 6, 2025 15:02
@jbrinkman jbrinkman merged commit 2bd6893 into main Jan 6, 2025
17 of 18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/jbrinkman-bzpopmin branch January 6, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrinkman @Yury-Fridlyand @tjzhang-BQ @prateek-kumar-improving