Fixes to resp2_replies.json and resp3_replies.json

[gmbnomis]

Fix keys, add missing commands/options, replace Redis/master

[stockholmux]

@zuiderkwast Refresh my memory: these reply JSON files are somehow generated?

I think @gmbnomis' effort here is worthy but I'm not sure of the right way to get it into the docs if it is generated.

[zuiderkwast]

I don't think they are generated. The bulk of it is markdown text, not types. IIRC they were extracted from the command markdown files some time in the past.

[zuiderkwast]

Very good, thanks!

Did you test this by generating man pages to review the result?

I opened this for the website: valkey-io/valkey-io.github.io#185

A problem with not having this on the website is that contibutors forget to update these files, so they become more and more outdated.

I would actually like to put this content back into each command's markdown file under a Reply heading, to eliminare the need for special handling. Looking at the history, it was in each markdown file earlier.

[zuiderkwast]

Both names exist for backward compatibility. We should probably duplicate these for both the primary and master subcommands.

[gmbnomis]

I just did "robotic" replacements here, but actually:

1. The sentinel commands appear only in the resp3 file
2. The sentinel command documentation lives outside of the regular command documentation anyway: https://valkey.io/topics/sentinel/#sentinel-api

I tend to remove the Sentinel commands from here. But I can also duplicate these both for master/primary and resp2/resp3 respectively if we intend to make the sentinel commands "first class citizens" in the future.

[gmbnomis]

Did you test this by generating man pages to review the result?

I looked at some of the web pages and some man pages (especially ZSCAN and HSCAN).

I opened this for the website: valkey-io/valkey-io.github.io#185

valkey-io/valkey-io.github.io#183 😀

I would actually like to put this content back into each command's markdown file under a Reply heading, to eliminare the need for special handling. Looking at the history, it was in each markdown file earlier.

Yes, putting them back into the command's markdown file might be a good idea longer term (or generate them automatically from the command JSONs).

[zuiderkwast]

Awesome, then let's merge this asap. We can improve more in the future.

[zuiderkwast]

(or generate them automatically from the command JSONs)

The descriptive text is not in the commnad json though. You mean we should move it there?

[gmbnomis]

The descriptive text is not in the commnad json though. You mean we should move it there?

My original intention was to eliminate duplication between the per-command JSON files and the RESP2/RESP3 files. Ideally, the JSON files would contain sufficient information to auto-generate the reply section(s) in the documentation, with the possibility of adding more descriptive text in this repository.

However, upon closer examination, this approach is flawed: the per-command JSON files lack adequate type information for RESP3 responses. Given this limitation, it seems we may need to accept the duplication.