Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes part 3, various topics pages #197

Merged
merged 19 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions topics/admin.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ description: Advice for configuring and managing Valkey in production

### Linux

* Deploy Valkey using the Linux operating system. Valkey is also tested on OS X, and from time to time on FreeBSD and OpenBSD systems. However, Linux is where most of the stress testing is performed, and where most production deployments are run.
* Deploy Valkey using the Linux operating system.
Valkey is also tested on macOS and FreeBSD, and from time to time on other OpenBSD, NetBSD, DragonFlyBSD and Solaris-derived systems.
zuiderkwast marked this conversation as resolved.
Show resolved Hide resolved
However, Linux is where most of the stress testing is performed, and where most production deployments are run.

* Set the Linux kernel overcommit memory setting to 1. Add `vm.overcommit_memory = 1` to `/etc/sysctl.conf`. Then, reboot or run the command `sysctl vm.overcommit_memory=1` to activate the setting. See [FAQ: Background saving fails with a fork() error on Linux?](faq.md#background-saving-fails-with-a-fork-error-on-linux) for details.

Expand Down Expand Up @@ -37,14 +39,13 @@ description: Advice for configuring and managing Valkey in production

### Security

* By default, Valkey does not require any authentication and listens to all the network interfaces. This is a big security issue if you leave Valkey exposed on the internet or other places where attackers can reach it. See for example [this attack](http://antirez.com/news/96) to see how dangerous it can be. Please check our [security page](security.md) and the [quick start](quickstart.md) for information about how to secure Valkey.
* By default, Valkey does not require any authentication and listens to all the network interfaces. This is a big security issue if you leave Valkey exposed on the internet or other places where attackers can reach it. Please check our [security page](security.md) and the [quick start](quickstart.md) for information about how to secure Valkey.

## Running Valkey on EC2

* Use HVM based instances, not PV based instances.
* Do not use old instance families. For example, use m3.medium with HVM instead of m1.medium with PV.
* The use of Valkey persistence with EC2 EBS volumes needs to be handled with care because sometimes EBS volumes have high latency characteristics.
* You may want to try the new diskless replication if you have issues when replicas are synchronizing with the primary.
* You may want to try diskless replication if you have issues when replicas are synchronizing with the primary.

## Upgrading or restarting a Valkey instance without downtime

Expand Down
31 changes: 17 additions & 14 deletions topics/command-tips.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,40 +3,43 @@ title: "Command tips"
description: Get additional information about a command
---

Command tips are an array of strings.
This page documents a small part of the reply of the [`COMMAND`](../command.md).
In the reply of the COMMAND command, each command is represented by an array.
The 8th element in this array is the command tips.
It's an array of strings.

These provide Valkey clients with additional information about the command.
The information can instruct Valkey Cluster clients as to how the command should be executed and its output processed in a clustered deployment.

Unlike the command's flags (see the 3rd element of `COMMAND`'s reply), which are strictly internal to the server's operation, tips don't serve any purpose other than being reported to clients.
Unlike the command's flags (see the 3rd element of [`COMMAND`](../command.md)'s reply), which are strictly internal to the server's operation, tips don't serve any purpose other than being reported to clients.

Command tips are arbitrary strings.
However, the following sections describe proposed tips and demonstrate the conventions they are likely to adhere to.
The following sections describe the command tips in use so far.
zuiderkwast marked this conversation as resolved.
Show resolved Hide resolved

## nondeterministic_output
## `nondeterministic_output`

This tip indicates that the command's output isn't deterministic.
That means that calls to the command may yield different results with the same arguments and data.
That difference could be the result of the command's random nature (e.g., `RANDOMKEY` and `SPOP`); the call's timing (e.g., `TTL`); or generic differences that relate to the server's state (e.g., `INFO` and `CLIENT LIST`).

**Note:**
Prior to Redis OSS 7.0, this tip was the _random_ command flag.
Prior to Redis OSS 7.0, this tip was the `random` command flag.

## nondeterministic_output_order
## `nondeterministic_output_order`

The existence of this tip indicates that the command's output is deterministic, but its ordering is random (e.g., `HGETALL` and `SMEMBERS`).

**Note:**
Prior to Redis OSS 7.0, this tip was the _sort_\__for_\__script_ flag.
Prior to Redis OSS 7.0, this tip was the `sort_for_script` flag.

## request_policy
## `request_policy:`*value*

This tip can help clients determine the shards to send the command in clustering mode.
The default behavior a client should implement for commands without the _request_policy_ tip is as follows:
The default behavior a client should implement for commands without the `request_policy` tip is as follows:

1. The command doesn't accept key name arguments: the client can execute the command on an arbitrary shard.
1. For commands that accept one or more key name arguments: the client should route the command to a single shard, as determined by the hash slot of the input keys.

In cases where the client should adopt a behavior different than the default, the _request_policy_ tip can be one of:
In cases where the client should adopt a behavior different than the default, the `request_policy` tip can be one of:

- **all_nodes:** the client should execute the command on all nodes - primaries and replicas alike.
An example is the `CONFIG SET` command.
Expand All @@ -53,10 +56,10 @@ In cases where the client should adopt a behavior different than the default, th
However, note that `SUNIONSTORE` isn't considered as _multi_shard_ because all of its keys must belong to the same hash slot.
- **special:** indicates a non-trivial form of the client's request policy, such as the `SCAN` command.

## response_policy
## `response_policy:`*value*

This tip can help clients determine the aggregate they need to compute from the replies of multiple shards in a cluster.
The default behavior for commands without a _request_policy_ tip only applies to replies with of nested types (i.e., an array, a set, or a map).
The default behavior for commands without a `request_policy` tip only applies to replies with of nested types (i.e., an array, a set, or a map).
The client's implementation for the default behavior should be as follows:

1. The command doesn't accept key name arguments: the client can aggregate all replies within a single nested data structure.
Expand All @@ -65,7 +68,7 @@ These should be packed in a single in no particular order.
1. For commands that accept one or more key name arguments: the client needs to retain the same order of replies as the input key names.
For example, `MGET`'s aggregated reply.

The _response_policy_ tip is set for commands that reply with scalar data types, or when it's expected that clients implement a non-default aggregate.
The `response_policy` tip is set for commands that reply with scalar data types, or when it's expected that clients implement a non-default aggregate.
This tip can be one of:

* **one_succeeded:** the clients should return success if at least one shard didn't reply with an error.
Expand Down
4 changes: 1 addition & 3 deletions topics/data-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,4 @@ The [HyperLogLog](hyperloglogs.md) data structures provide probabilistic estimat
To extend the features provided by the included data types, use one of these options:

1. Write your own custom [server-side functions in Lua](programmability.md).
1. Write your own Valkey module using the [modules API](modules-intro.md) or check out the [community-supported modules](../modules/).

<hr>
2. Write your own Valkey module using the [modules API](modules-intro.md) or check out the modules(../modules/).
zuiderkwast marked this conversation as resolved.
Show resolved Hide resolved
Loading
Loading