-
Notifications
You must be signed in to change notification settings - Fork 6
tests #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
butler54
wants to merge
96
commits into
validatedpatterns:main
Choose a base branch
from
butler54:tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tests #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
butler54
commented
Apr 19, 2025
- Move the common slim + multisource test into Makefile
- Drop last bit of operator-install and the common symlink
- Drop reference-output.yaml as it makes little sense in the slimmed common
- Remove ansible code in favor of external collection
- Make adjustments for ansible code moving into separate collection repo
- Add a note about the changes in common
- Add qe-tests target
- Remove assorted detritus
- We don't have charts to test anymore
- Drop lint.sh and its target in Makefile
- Drop test.sh and its target in Makefile and also kubeconform
- Read PATTERN_INSTALL_CHART from the env as well if it exists
- Update secret backend change script
- Update preview script
- Introduce PATTERN_DISCONNECTED_HOME
- Update Makefile to reflect a warning if no storageclass is present
- Fix iib loading playbook name
- Improve validate-origin
- Make the make install output less daunting
- Record the exit code at the right time
- Fix path when invoking the qe run_test.sh script
- Add a warning when pattern folder and pattern name differ
- Drop some old and unused prereq test
- Fix validated-schema make target
- Wait some more before giving up
- Fix argo-healthcheck target
- Push TARGET_SITE into the in-container variables
- Do not bind mount /etc/pki blindly
- Add a CI job for pattern.sh
- Allow TARGET_BRANCH to be overridden
- Restrict GH actions only to certain files
- propagate the env var EXTRA_PLAYBOOK_OPTS to our ansible-playbook commands
- update how to make common subtree
- feat: add container build
- fix: add missing files
- fix: correct bad key
- feat: correct URL
- feat: correct URL
- feat: target revision
- feat: add environmental variable
- fix: remove pod privledges
- fix: insecure
- feat: add stuff
- fix: correct python script
- feat: correct to use coco containers
- fix: only change one thing
- feat: add ghcr image
- fix: refer to KBS
- chore: update path
- feat: clean up chart locations
- feat: disable lets-encrypt cert
- fix: add back in default project
- feat: correct parameter name
- fix: need lets encrypt
- fix: more robust ssh support
- fix: coco encrypted
- fix: uncommited changes
- fix: relocate chart
- fix: definition
- fix: correct name
- fix: correct name
- fix: correct name
- fix: correct file
- feat: update to latest test skeleton
- Removed previous version of common to convert to subtree from https://github.com/validatedpatterns/common.git main
- fix: clean out tests separately
- feat: add compatible qe tests
This way yq is not required on the host. Tested as follows: * No value set (assumes default is false) ❯ cat values-global.yaml --- global: pattern: multicloud-gitops options: useCSV: false syncPolicy: Automatic installPlanApproval: Automatic main: clusterGroupName: hub # multiSourceConfig: # enabled: true ❯ ./pattern.sh make validate-prereq make -f common/Makefile validate-prereq make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' You must set ".main.multiSourceConfig.enabled: true" in your 'values-global.yaml' file because your common subfolder is the slimmed down version with no helm charts in it make[1]: *** [common/Makefile:161: validate-prereq] Error 1 make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' make: *** [Makefile:12: validate-prereq] Error 2 * Value set to false ❯ cat values-global.yaml --- global: pattern: multicloud-gitops options: useCSV: false syncPolicy: Automatic installPlanApproval: Automatic main: clusterGroupName: hub multiSourceConfig: enabled: false ❯ ./pattern.sh make validate-prereq make -f common/Makefile validate-prereq make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' You must set ".main.multiSourceConfig.enabled: true" in your 'values-global.yaml' file because your common subfolder is the slimmed down version with no helm charts in it make[1]: *** [common/Makefile:161: validate-prereq] Error 1 make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' make: *** [Makefile:12: validate-prereq] Error 2 * Value set to true ❯ cat values-global.yaml --- global: pattern: multicloud-gitops options: useCSV: false syncPolicy: Automatic installPlanApproval: Automatic main: clusterGroupName: hub multiSourceConfig: enabled: true ❯ ./pattern.sh make validate-prereq make -f common/Makefile validate-prereq make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Move the common slim + multisource test into Makefile
Drop last bit of operator-install and the common symlink
Drop reference-output.yaml as it makes little sense in the slimmed common
Factor out ansible into separate collection repo
Add a note about the changes in common
Remove assorted detritus
Add qe-tests target
Read PATTERN_INSTALL_CHART from the env as well if it exists
The script is used in make secrets-backend-*. Update needed for slimed common.
Now the preview will work with remote charts, and local charts as well. Default helm registry will be oci://quay.io/repository/hybridcloudpatterns/.
Fix scripts after common slim
When doing disconnected installations this allows for setting a single variable pointing to the internal disconnected registry.
Introduce PATTERN_DISCONNECTED_HOME
…quirement Update Makefile to reflect a warning if no storageclass is present
After slimming common down the playbook needs renaming because collections have slightly different naming constraints. Previous error: ❯ ./pattern.sh make load-iib make -f common/Makefile load-iib make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' ERROR! the playbook: rhvp.cluster_utils.iib-ci could not be found make[1]: *** [common/Makefile:117: load-iib] Error 1 make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops' make: *** [Makefile:12: load-iib] Error 2
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.