Repository navigation
Conversation
overrides/values-snp-vcek.yaml (generated by `make snp-gen-overrides`,
which sets kbs.snp.vcekSecrets so the trustee chart mounts each node's
VCEK certificate for offline SNP attestation) was never referenced by
the baremetal clustergroup's trustee application. The KBS SNP verifier
therefore had no VCEK and attestation failed with a 401 ("Failed to
fetch VCEK from any configured source").
- Add overrides/values-snp-vcek.yaml to the trustee application's
extraValueFiles in values-baremetal.yaml, alongside the existing
values-trustee.yaml. Helm natively deep-merges both files' kbs.* maps,
so no custom merge logic is needed.
- Commit overrides/values-snp-vcek.yaml as a placeholder
(kbs.snp.enabled: true, kbs.snp.vcekSecrets: []) so a fresh checkout
resolves cleanly.
- scripts/gen-snp-vcek-overrides.sh regenerates this file with a plain
heredoc overwrite (no awk/parsing needed, since the file is wholly
owned by the generator and contains nothing hand-written).
Fixes validatedpatterns#156
butler54
approved these changes
Oct 7, 2026
butler54
left a comment
butler54
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thank you for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
values-baremetal.yaml— add/overrides/values-snp-vcek.yamlto thetrusteeapplication'sextraValueFiles, alongside the existing/overrides/values-trustee.yaml. Helm natively deep-merges both files'kbs.*maps — no custom merge logic needed.overrides/values-snp-vcek.yaml(new) — committed as a placeholder(
kbs.snp.enabled: true,kbs.snp.vcekSecrets: []) so a fresh checkoutalways resolves the
extraValueFilesreference.scripts/gen-snp-vcek-overrides.sh— regenerates this file with aplain heredoc overwrite.