.net 8

.github/workflows/build.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Setup .NET SDK
         uses: actions/setup-dotnet@v1
         with:
-          dotnet-version: '7.0.101'
+          dotnet-version: '8.0.x'
       - name: Build
         run: dotnet build src/VSPoll.API.sln
       - name: Test

.editorconfig → src/.editorconfig

@@ -1,4 +1,5 @@
 # To learn more about .editorconfig see https://aka.ms/editorconfigdocs
+dotnet_remove_unnecessary_suppression_exclusions = category: ReSharper
 ###############################
 # Core EditorConfig Options   #
 ###############################

src/VSPoll.API.UnitTest/Utils/MathUtilsTests.cs

@@ -50,14 +50,7 @@ public void NormalizePercentages_Changes()
             19.161676646706585m,
             22.75449101796407m,
         }.ToList();
-        var expected = new[]
-        {
-            19,
-            21,
-            19,
-            18,
-            23,
-        };
+        int[] expected = [19, 21, 19, 18, 23];
 
         var options = percentages.Select(percentage => new PollOption { Percentage = percentage }).ToList();
         MathUtils.NormalizePercentages(options);

src/VSPoll.API.UnitTest/VSPoll.API.UnitTest.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7</TargetFramework>
+    <TargetFramework>net8</TargetFramework>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

src/VSPoll.API/Controllers/OptionController.cs

@@ -15,18 +15,8 @@ namespace VSPoll.API.Controllers;
 #pragma warning disable IDE0079
 [SuppressMessage("ReSharper", "ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract")]
 #pragma warning restore IDE0079
-public class OptionController : Controller
+public class OptionController(IPollService pollService, IOptionService optionService, IUserService userService) : ControllerBase
 {
-    private readonly IPollService pollService;
-    private readonly IOptionService optionService;
-    private readonly IUserService userService;
-    public OptionController(IPollService pollService, IOptionService optionService, IUserService userService)
-    {
-        this.pollService = pollService;
-        this.optionService = optionService;
-        this.userService = userService;
-    }
-
     /// <summary>
     /// Gets the voters of an option
     /// </summary>

src/VSPoll.API/Controllers/PollController.cs

@@ -18,18 +18,8 @@ namespace VSPoll.API.Controllers;
 #pragma warning disable IDE0079
 [SuppressMessage("ReSharper", "ConditionIsAlwaysTrueOrFalseAccordingToNullableAPIContract")]
 #pragma warning restore IDE0079
-public class PollController : Controller
+public class PollController(IPollService pollService, IOptionService optionService, IUserService userService) : ControllerBase
 {
-    private readonly IPollService pollService;
-    private readonly IOptionService optionService;
-    private readonly IUserService userService;
-    public PollController(IPollService pollService, IOptionService optionService, IUserService userService)
-    {
-        this.pollService = pollService;
-        this.optionService = optionService;
-        this.userService = userService;
-    }
-
     /// <summary>
     /// Gets data from a poll
     /// </summary>

src/VSPoll.API/Dockerfile

@@ -1,11 +1,11 @@
 #See https://aka.ms/containerfastmode to understand how Visual Studio uses this Dockerfile to build your images for faster debugging.
 
-FROM mcr.microsoft.com/dotnet/aspnet:7.0-alpine AS base
+FROM mcr.microsoft.com/dotnet/aspnet:8.0-alpine AS base
 WORKDIR /app
 EXPOSE 80
 EXPOSE 443
 
-FROM mcr.microsoft.com/dotnet/sdk:7.0-alpine AS build
+FROM mcr.microsoft.com/dotnet/sdk:8.0-alpine AS build
 WORKDIR /src
 COPY ["VSPoll.API.csproj", "VSPoll.API/"]
 RUN dotnet restore "VSPoll.API/VSPoll.API.csproj"

src/VSPoll.API/Persistence/Contexts/PollContext.cs

@@ -3,7 +3,7 @@
 
 namespace VSPoll.API.Persistence.Contexts;
 
-public class PollContext : DbContext
+public class PollContext(DbContextOptions<PollContext> contextOptions) : DbContext(contextOptions)
 {
     public DbSet<Poll> Polls { get; set; } = null!;
     public DbSet<PollOption> PollOptions { get; set; } = null!;
@@ -12,6 +12,4 @@ public class PollContext : DbContext
 
     protected override void OnModelCreating(ModelBuilder modelBuilder)
         => modelBuilder.Entity<PollVote>().HasKey(vote => new { vote.OptionId, vote.UserId });
-
-    public PollContext(DbContextOptions<PollContext> contextOptions) : base(contextOptions) { }
 }

src/VSPoll.API/Persistence/Repositories/OptionRepository.cs

@@ -8,11 +8,8 @@
 
 namespace VSPoll.API.Persistence.Repositories;
 
-public class OptionRepository : IOptionRepository
+public class OptionRepository(PollContext context) : IOptionRepository
 {
-    private readonly PollContext context;
-    public OptionRepository(PollContext context) => this.context = context;
-
     public Task<bool> CheckIfOptionExists(Guid id)
         => context.PollOptions.AnyAsync(option => option.Id == id);
 

src/VSPoll.API/Persistence/Repositories/PollRepository.cs

@@ -8,11 +8,8 @@
 
 namespace VSPoll.API.Persistence.Repositories;
 
-public class PollRepository : IPollRepository
+public class PollRepository(PollContext context) : IPollRepository
 {
-    private readonly PollContext context;
-    public PollRepository(PollContext context) => this.context = context;
-
     public Task<bool> CheckIfPollExists(Guid id)
         => context.Polls.AnyAsync(poll => poll.Id == id);
 

src/VSPoll.API/Persistence/Repositories/UserRepository.cs

@@ -5,11 +5,8 @@
 
 namespace VSPoll.API.Persistence.Repositories;
 
-public class UserRepository : IUserRepository
+public class UserRepository(PollContext context) : IUserRepository
 {
-    private readonly PollContext context;
-    public UserRepository(PollContext context) => this.context = context;
-
     public async Task AddOrUpdateUserAsync(User user)
     {
         if (await context.Users.AnyAsync(u => u.Id == user.Id))

src/VSPoll.API/Services/OptionService.cs

@@ -7,12 +7,8 @@
 
 namespace VSPoll.API.Services;
 
-public class OptionService : IOptionService
+public class OptionService(IOptionRepository optionRepository) : IOptionService
 {
-    private readonly IOptionRepository optionRepository;
-    public OptionService(IOptionRepository optionRepository)
-        => this.optionRepository = optionRepository;
-
     public Task<bool> CheckIfOptionExistsAsync(Guid id)
         => optionRepository.CheckIfOptionExists(id);
 

src/VSPoll.API/Services/PollService.cs

@@ -11,16 +11,8 @@
 
 namespace VSPoll.API.Services;
 
-public class PollService : IPollService
+public class PollService(IPollRepository pollRepository, IOptionRepository optionRepository) : IPollService
 {
-    private readonly IPollRepository pollRepository;
-    private readonly IOptionRepository optionRepository;
-    public PollService(IPollRepository pollRepository, IOptionRepository optionRepository)
-    {
-        this.pollRepository = pollRepository;
-        this.optionRepository = optionRepository;
-    }
-
     public Task<bool> CheckIfPollExistsAsync(Guid id)
         => pollRepository.CheckIfPollExists(id);
 

src/VSPoll.API/Services/UserService.cs

@@ -10,16 +10,8 @@
 
 namespace VSPoll.API.Services;
 
-public class UserService : IUserService
+public class UserService(IUserRepository userRepository, IConfiguration configuration) : IUserService
 {
-    private readonly IUserRepository userRepository;
-    private readonly IConfiguration configuration;
-    public UserService(IUserRepository userRepository, IConfiguration configuration)
-    {
-        this.userRepository = userRepository;
-        this.configuration = configuration;
-    }
-
     public bool Authenticate(Authentication authentication, [NotNullWhen(false)] out string? error)
     {
         var dataCheck = $"auth_date={authentication.AuthDate}\nfirst_name={authentication.FirstName}\nid={authentication.Id}";
@@ -32,7 +24,7 @@ public bool Authenticate(Authentication authentication, [NotNullWhen(false)] out
         if (authentication.Username is not null)
             dataCheck += $"\nusername={authentication.Username}";
 
-        var token = configuration.GetSection("Secrets").GetValue<string>("BotToken");
+        var token = configuration.GetSection("Secrets").GetValue<string>("BotToken")!;
         var secretKey = SHA256.HashData(Encoding.UTF8.GetBytes(token));
         using HMACSHA256 hmac = new(secretKey);
         var testHash = hmac.ComputeHash(Encoding.UTF8.GetBytes(dataCheck));

src/VSPoll.API/VSPoll.API.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net7</TargetFramework>
+    <TargetFramework>net8</TargetFramework>
     <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
     <Nullable>enable</Nullable>
   </PropertyGroup>