Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementary OS 7 App Template #26

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

colinkiama
Copy link
Member

An elementary OS 7 app template that follows best practices from elementary.

@colinkiama colinkiama marked this pull request as draft April 8, 2023 10:49
@colinkiama colinkiama marked this pull request as ready for review April 8, 2023 12:21
@Prince781
Copy link
Member

Perhaps we should rename the old template to eos6 and make this the default.

@colinkiama
Copy link
Member Author

colinkiama commented Apr 8, 2023

Oh yeah, that makes sense. This would be similar to what happens with the gtk and gtk3 templates.

Should I make this change myself?

@Prince781
Copy link
Member

Should I make this change myself?

Yeah, go ahead

@colinkiama
Copy link
Member Author

The elementary OS templates have been renamed now

@colinkiama colinkiama marked this pull request as draft April 8, 2023 19:16
@colinkiama colinkiama marked this pull request as ready for review April 8, 2023 19:29
@colinkiama
Copy link
Member Author

colinkiama commented Apr 9, 2023

I've noticed an issue with libadwaita styling not being overridden with elementary styling when building and running the flatpak through GNOME Builder.

Here's what the app looks like when running it from GNOME Builder:
image

However, this is what the app looks like when running it using VS Code's Flatpak extension (Note: I am using the non-flatpak version of VS Code):
image

This is the expected behaviour. The flatpak also has elementary styling after installing it using the flatpak and flatpak-builder cli commands.

I'm not sure what's causing this issue. I suspect that it has something to do with GNOME Builder.

@Prince781
Copy link
Member

@colinkiama I just wrapped up a bunch of merge requests. You'll have to rebase (git pull --rebase origin master)

@colinkiama
Copy link
Member Author

I decided to drop libadwaita from the template. The issue with GNOME Builder is now fixed. This is ready to be merged now.

@Prince781
Copy link
Member

I don't remember why we included libadwaita in the template. Was it ever a part of the elementary SDK?

@colinkiama
Copy link
Member Author

elementary has been relying on libhandy a lot for gestures and some of the widgets it comes with.

I assumed that it would be just as easy to include libadwaita as it's supposed to be the successor for libhandy for GTK 4 apps. It turns out, it's not as easy as it seems.

Libadwaita is not in the elementary-sdk package but it is available in the elementary flatpak platform package.

@colinkiama
Copy link
Member Author

Hi, just following up on this PR

@colinkiama
Copy link
Member Author

@Prince781 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants