Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Broken graphQL query comparisons #2356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BhaskarChezhiyan
Copy link

Overview

graphQL queries with conditions that have an equal or not equal comparison with 0 as operand value are not evaluated properly.

Reproduce

import vaex
import pandas as pd
from decimal import Decimal

df = vaex.from_pandas(pd.Dataframe(data=[[7]], columns=['dummy'] ))

query = """
query($where: BoolExp!, $limit: Int!){
          df(where: $where) { row(limit: $limit){
                               dummy
                               }
                        }
                  }
"""
variables = {'limit': Decimal('10'), 'where': {'dummy': {'_eq': Decimal('0')}}}
output = df.graphql.execute(query, variable_values=variables)

print(output.errors)

Changes

  1. Added null check to Compare class _eq and _neq checks.
  2. Fixed BooleanCompare class to inherit from Compare class rather than NumberCompare.

2. Fixed BooleanCompare class to inherit from Compare class rather than NumberCompare.
@BhaskarChezhiyan BhaskarChezhiyan changed the title Broken Graphql Query conditions [Bug Fix] Broken graphQL query comparisons Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants