-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make URLSession injectable into Networking
for easy mocking.
#115
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Robin Malhotra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 92.73% 92.76% +0.02%
==========================================
Files 64 64
Lines 3110 3108 -2
==========================================
- Hits 2884 2883 -1
+ Misses 226 225 -1
Continue to review full report at Codecov.
|
I think it would be better to keep both init methods, one with session configuration and one with session. What do you think? |
That works too! Have the init with |
Yes, please 😉 |
It should work if you drop default parameter for |
Signed-off-by: Robin Malhotra <[email protected]>
Done 😄 |
Great! Any idea why tests are failing? |
@vadymmarkov I just tried running those tests locally. The test that failed on CI ( Could you try running it locally on your computer to see if you can reproduce it? |
Wait a second, I noticed the tests are running on Xcode 9.4. Could that be a cause? |
Got a branch with an Xcode 10.1 image in the |
Hi 👋 @vadymmarkov gentle nudge, was hoping you could take a look at this 😬 |
Signed-off-by: Robin Malhotra [email protected]