-
Notifications
You must be signed in to change notification settings - Fork 86
refactor!: Text Area base styles #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's consider changing this PR to target main
branch instead of base-styles
.
Yeah, I was wondering about that. Sure, let’s do that. |
Oh, right, need to rebase first 😅 |
It's better not to rebase |
Thanks, I’ll do that. |
|
We don't need it, let's just keep old styles file named as |
Yeah, I figured it out. I got confused when field-shared-styles.js was no longer there, because it was renamed. |
Replaced with #9219. |
Supported custom properties
All the same properties as for
<vaadin-text-field>
: #8917