Skip to content

refactor!: Text Area base styles #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

refactor!: Text Area base styles #9214

wants to merge 2 commits into from

Conversation

jouni
Copy link
Member

@jouni jouni commented May 20, 2025

Supported custom properties

All the same properties as for <vaadin-text-field>: #8917

Screenshot 2025-05-20 at 13 04 00

@jouni jouni requested review from web-padawan and vursen May 20, 2025 10:04
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider changing this PR to target main branch instead of base-styles.

@jouni
Copy link
Member Author

jouni commented May 20, 2025

Yeah, I was wondering about that. Sure, let’s do that.

@jouni jouni changed the base branch from base-styles to main May 20, 2025 11:21
@jouni
Copy link
Member Author

jouni commented May 20, 2025

Oh, right, need to rebase first 😅

@jouni jouni changed the base branch from main to base-styles May 20, 2025 11:21
@web-padawan
Copy link
Member

It's better not to rebase base-styles branch itself for now as it would be quite tricky.
I'd rather re-create this branch from main and apply only relevant commit there.

@jouni
Copy link
Member Author

jouni commented May 20, 2025

Thanks, I’ll do that.

@jouni
Copy link
Member Author

jouni commented May 20, 2025

Oh, but we should first merge #9208 No, that’s not it.

@web-padawan
Copy link
Member

Oh, but we should first merge #9208

We don't need it, let's just keep old styles file named as vaadin-text-area-core-styles.js and then name the new one as vaadin-text-area-base-styles.js - this is how it is done in other components. Then the base styles will be loaded.

@jouni
Copy link
Member Author

jouni commented May 20, 2025

Yeah, I figured it out. I got confused when field-shared-styles.js was no longer there, because it was renamed.

@jouni
Copy link
Member Author

jouni commented May 20, 2025

Replaced with #9219.

@jouni jouni closed this May 20, 2025
@jouni jouni deleted the base-text-area branch May 20, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants