Skip to content

refactor!: drop deprecated Material theme from all components #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented May 19, 2025

Description

The Material theme has been marked as deprecated in V24.8, let's remove it in V25.

Type of change

  • Breaking change

Copy link

@sissbruecker
Copy link
Contributor

There's a few leftovers, mostly in comments:

Targets
    Occurrences of 'material' in Directory /Users/sascha/dev/vaadin/web-components
Found occurrences in Directory /Users/sascha/dev/vaadin/web-components  (10 usages found)
      (2 usages found)
        DEVELOPMENT.md  (1 usage found)
            246 Run the script to bump static version getters in `ElementMixin`, `Lumo` and `Material`:
        wtr-utils.js  (1 usage found)
            21 'The Material theme is deprecated and will be removed in Vaadin 25.',
    packages/button/theme/lumo  (1 usage found)
        vaadin-button-styles.js  (1 usage found)
            236   /* Vaadin icons are based on a 16x16 grid (unlike Lumo and Material icons with 24x24), so they look too big by default */
    packages/input-container/theme/lumo  (1 usage found)
        vaadin-input-container-styles.js  (1 usage found)
            111     /* Vaadin icons are based on a 16x16 grid (unlike Lumo and Material icons with 24x24), so they look too big by default */
    packages/tabs/theme/lumo  (1 usage found)
        vaadin-tab-styles.js  (1 usage found)
            158     /* Vaadin icons are based on a 16x16 grid (unlike Lumo and Material icons with 24x24), so they look too big by default */
    packages/vaadin-themable-mixin  (2 usages found)
        register-styles.js  (1 usage found)
            9 * This is for use internally by Lumo and Material styles.
        vaadin-themable-mixin.js  (1 usage found)
            257 if (moduleName.startsWith('lumo-') || moduleName.startsWith('material-')) {
    packages/vaadin-themable-mixin/test  (3 usages found)
        themable-mixin.test.js  (3 usages found)
            158 'material-test-style-override-styles',
            327 it('material should override vaadin module styles', () => {
            335 it('should override material module styles', () => {

Probably easier to do this as a follow-up.

@web-padawan web-padawan merged commit dc5352f into main May 20, 2025
9 checks passed
@web-padawan web-padawan deleted the v25/drop-material branch May 20, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants