Skip to content

fix: sync top group if necessary even when dropdown is opened #9095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR makes sure the topGroup items are always in sync with the selected items even when the dropdown is opened. The topGroup items are used to hold the references to the items that will be displayed on top when selectedItemsOnTop is set true. This fix does not change the intended behaviour of retaining the visible item order when the selected items are updated while the dropdown is opened.

Fixes #7161

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

sonarqubecloud bot commented May 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MultiSelectComboBox] Selected items on top does not work properly with custom renderers
2 participants