fix: ensure row cell parts are in place after setting rowDetailsRenderer #10443
+23
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
commented
Nov 5, 2025
| */ | ||
| __updateRow(row) { | ||
| this.__a11yUpdateRowRowindex(row); | ||
| this.__updateRowOrderParts(row); |
There was a problem hiding this comment.
All row parts are now updated as part of __updateRow, which makes it possible to call this method from the row details mixin after __initRow.
vursen
changed the title
tomivirkki
approved these changes
Nov 5, 2025
vursen
deleted the
ensure-row-order-state-parts-after-setting-row-details-renderer
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes a bug where CSS parts like
last-row-cellcould be removed and not restored on cells ifrowDetailsRendererwas changed after the column tree was already constructed.Finding from #10331
Type of change