Skip to content

Conversation

@web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 21, 2025

Description

This is a prototype PR adding an MVP of vaadin-month-picker.

The component itself is a significant rewrite of the vcf-month-picker with some adjustments:

  • Instead of wrapping vaadin-text-field, the component uses mixins e.g. InputControlMixin etc
  • The vaadin-month-picker-overlay is rewritten to use native popover to align with other components
  • The vaadin-month-picker-overlay-content uses slotted vaadin-month-picker-button elements
  • The component is updated to use LumoInjectionMixin with some small tweaks to the Lumo theme
  • Added I18nMixin, modified the default i18n structure, added prevYear and nextYear strings
  • Modified checkValidity() and some other logic around detecting and dispatching change event
  • Removed getters e.g. formattedValue, yearMonth and inputValue (might add later if needed)

Type of change

  • Prototype

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant