Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom gen-typescript-declarations #117

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

web-padawan
Copy link
Member

Include fix for @attribute JSDoc tags for properties needed by web-component-analyzer, see Polymer/tools#3508

This is needed to fix vaadin/vaadin-grid#1774 and vaadin/vaadin-combo-box#896

Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally by using npm link and copied the output for vaadin-column.d.ts into the ts-vaadin-examples project's file and the previous warning regarding attributes was out.

LGTM

@web-padawan web-padawan merged commit 660878c into master Jul 16, 2020
@web-padawan web-padawan deleted the custom-ts-defs branch July 16, 2020 11:37
web-padawan pushed a commit that referenced this pull request Jul 16, 2020
## [0.26.4](v0.26.3...v0.26.4) (2020-07-16)

### Bug Fixes

* use custom gen-typescript-declarations ([#117](#117)) ([660878c](660878c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSDoc to document attributes for camel case properties
2 participants