feat: Support UUID filtering in PropertyStringFilter #3363
Conversation
|
|
| } else if (javaType == UUID.class) { | ||
| switch (this.filter.getMatcher()) { | ||
| case EQUALS -> { | ||
| return criteriaBuilder.equal(propertyPath, UUID.fromString(value)); | ||
| } | ||
| case CONTAINS -> throw new IllegalArgumentException("A UUID cannot be filtered using contains"); | ||
| case GREATER_THAN -> | ||
| throw new IllegalArgumentException("A UUID cannot be filtered using greater than"); | ||
| case LESS_THAN -> throw new IllegalArgumentException("A UUID cannot be filtered using less than"); |
There was a problem hiding this comment.
Make sure your code is compliant with Java 17
There was a problem hiding this comment.
@cromoteca Thank you for reviewing my PR.
I've set my .java-version to 17 and run jenv local to confirm I'm on 17.
When I run ./mvnw clean package it runs without any errors.
What additional checks can I make?
There was a problem hiding this comment.
It's weird because in Java 17 enhanced switches must explicitly cover all possible cases and null is not covered here. But of course the compiler knows more than me and if it's happy I'm happy too.
packages/java/endpoint/src/test/java/com/vaadin/hilla/crud/TestObject.java
Outdated
Show resolved
Hide resolved
packages/java/endpoint/src/test/java/com/vaadin/hilla/crud/filter/FilterTransformerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hi, thanks for the PR. While we're reviewing it, could you, please, sign the CLA? We require it from all contributors. Here is the link again (same as in the comment): https://cla-assistant.io/vaadin/hilla?pullRequest=3363
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 115 115
Lines 8289 8289
Branches 1271 1271
=======================================
Hits 7203 7203
Misses 1072 1072
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
Allow users to pass a PropertyStringFilter for a UUID field.
Fixes #3362
Type of change
Checklist
Additional for
Featuretype of change