Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update flow gradle plugin after id change #3333

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Mar 7, 2025

this test is based on vaadin/flow#21096

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (9f8f7a9) to head (4e84588).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3333   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         115      115           
  Lines        8289     8289           
  Branches     1271     1271           
=======================================
  Hits         7203     7203           
  Misses       1072     1072           
  Partials       14       14           
Flag Coverage Δ
unittests 86.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ZheSun88 ZheSun88 changed the title [WIP] fix: update flow gradle plugin after id change fix: update flow gradle plugin after id change Mar 7, 2025
@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Mar 7, 2025

need the flow PR to be merged
then remove the change from pom on flow.version..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants