feat(generator-plugin-transfertypes): add generics & importing from the correct module #3318
Conversation
…metadata to transfer types
…ng instead of an array
...ypes/src/test/java/com/vaadin/hilla/parser/plugins/transfertypes/signals/SignalEndpoint.java
Show resolved
Hide resolved
...ages/java/parser-jvm-plugin-transfertypes/src/test/java/com/vaadin/hilla/signals/Signal.java
Show resolved
Hide resolved
...ertypes/src/main/java/com/vaadin/hilla/parser/plugins/transfertypes/TransferTypesPlugin.java
Outdated
Show resolved
Hide resolved
...ages/java/parser-jvm-plugin-transfertypes/src/test/java/com/vaadin/hilla/signals/Signal.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
- Coverage 86.89% 86.62% -0.28%
==========================================
Files 115 115
Lines 8289 8163 -126
Branches 1271 1261 -10
==========================================
- Hits 7203 7071 -132
- Misses 1072 1077 +5
- Partials 14 15 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The changes for the TransferTypePlugin and the Generator seems fine, but I guess the |
# Conflicts: # package-lock.json # packages/ts/generator-plugin-signals/package.json # packages/ts/react-crud/package.json
|
Fixes #3208
This pull request includes several changes across multiple files to enhance functionality and improve the codebase. The most important changes involve adding new annotations, refactoring methods, and updating dependencies. Below is a summary of the key changes:
Enhancements and New Features:
@FromModuleto specify module information for transfer types inpackages/java/runtime-plugin-transfertypes/src/main/java/com/vaadin/hilla/transfertypes/annotations/FromModule.java.Signalclasses and corresponding test cases to handle different signal types inpackages/java/parser-jvm-plugin-transfertypes/src/test/java/com/vaadin/hilla/signals/. [1] [2] [3] [4]Code Refactoring:
scanmethod inPlugininterface to provide a default implementation inpackages/java/parser-jvm-core/src/main/java/com/vaadin/hilla/parser/core/Plugin.java.TransferTypesPluginto handle new signal classes and added logic to replace signal classes with local signal records inpackages/java/parser-jvm-plugin-transfertypes/src/main/java/com/vaadin/hilla/parser/plugins/transfertypes/TransferTypesPlugin.java. [1] [2]Dependency and Import Management:
TransferTypesPluginand other related files.module-info.javato export the newannotationspackage inpackages/java/runtime-plugin-transfertypes/src/main/java/module-info.java.Testing and Validation:
packages/java/parser-jvm-plugin-transfertypes/src/test/java/com/vaadin/hilla/parser/plugins/transfertypes/signals/SignalTest.java.These changes collectively enhance the functionality and maintainability of the codebase by introducing new features, refactoring existing methods, and ensuring proper dependency management.