Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dynamically import atmosphere.js for SW context #2901

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

krissvaa
Copy link
Contributor

Fixes #2867

@krissvaa krissvaa force-pushed the fix/sw-context-access branch from f5f6170 to cf3a028 Compare November 11, 2024 17:11
@krissvaa krissvaa force-pushed the fix/sw-context-dynamic-import branch from 5c613c4 to 33b8cc7 Compare November 13, 2024 14:06
Env should be optional for other frameworks
Fixes #2867
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (cbd608c) to head (cd06ad9).

Files with missing lines Patch % Lines
packages/ts/frontend/src/FluxConnection.ts 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   86.61%   86.59%   -0.03%     
==========================================
  Files         115      115              
  Lines        8159     8166       +7     
  Branches     1257     1258       +1     
==========================================
+ Hits         7067     7071       +4     
- Misses       1077     1079       +2     
- Partials       15       16       +1     
Flag Coverage Δ
unittests 86.59% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lodin
Lodin previously requested changes Nov 14, 2024
@Lodin Lodin requested a review from platosha November 25, 2024 10:54
Base automatically changed from fix/sw-context-access to main November 25, 2024 14:49
Copy link

sonarqubecloud bot commented Apr 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA endpoint errors while called from SW
4 participants