Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormFillerTextIT related to model changes, and some imports cleanup. #20

Merged

Conversation

czp13
Copy link
Collaborator

@czp13 czp13 commented Feb 13, 2024

Description

Fixes and changes in the FormFillerTextIT related to the model change (deprecated text-davinci-003 to gpt-3.5-turbo-instruct).

  • The description is filled differently (not worse just a bit more verbose)
  • also date fills maybe not as stable (as we have 2-3 dates in the text, it can choose randomly it seems)

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

…e (deprecated text-davinci-003 to gpt-3.5-turbo-instruct), and some imports cleanup.
@czp13 czp13 requested review from mshabarov and manolo February 13, 2024 23:16
@czp13 czp13 changed the title fix: Fixes and changes in the FormFillerTextIT related to the model change (deprecated text-davinci-003 to gpt-3.5-turbo-instruct), and some imports cleanup. fix: FormFillerTextIT related to model changes, and some imports cleanup. Feb 14, 2024
@czp13 czp13 requested a review from mgarciavaadin February 14, 2024 08:19
manolo
manolo previously approved these changes Feb 16, 2024
@ZheSun88 ZheSun88 merged commit d183c84 into v24 Feb 16, 2024
2 checks passed
@ZheSun88 ZheSun88 deleted the fix/17-fixes-in-the-it-tests-related-to-the-model-change branch February 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants