Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-4489][External] Import item-level properties without annotations #948

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

JBWilkie
Copy link
Collaborator

Problem

When importing annotations to items in Darwin JSON 2.0, item-level property values are ignored if there are no annotations. This happens because before item-level properties, all properties were tied to annotations, so it made sense to skip import in these cases

However, item-level properties are independent of annotations and so should be able to be imported independently

Solution

Do not skip annotation files for import if they contain item-level properties but no annotations

Changelog

Allow import of item-level properties without annotations

@dorfmanrobert dorfmanrobert self-requested a review October 24, 2024 09:08
@JBWilkie JBWilkie merged commit 1a17d18 into master Oct 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants