Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace sha1 with sha256 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

IrisesD
Copy link

@IrisesD IrisesD commented Jan 17, 2024

Checklist

Motivation and Context

In crypt/crypt.go, the Encrypt and Decrypt functions use SHA-1 as the hash algorithms, which is insecure now because of the collisions. See Finding Collisions in the Full SHA-1
In order to avoid potential attacks, I suggest we replace all SHA-1 uses with SHA-256, which is a recommended algorithm for key management.

Description

  1. replace all SHA-1 algorithm uses with SHA-256 algorithm.
  2. remove the "crypto/sha1" import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant