Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libvirt readme #769

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update libvirt readme #769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a5bef3
Update libvirt readme
Etheryte Sep 9, 2020
5a521d1
Omit SCC sidenote from libvirt readme
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend_modules/libvirt/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
- change the `network_name` variable declaration to `null`
- optionally specify fixed MAC addresses by adding `mac = "CA:FE:BA:BE:00:01"` lines to VM modules
- if other sumaform users deploy to the same host, or different bridged hosts in the same network, uncomment the `name_prefix` variable declaration in the `base` module to specify a unique prefix for your VMs
- complete the `cc_password` variable in the `base` module
- if you have a [SUSE Customer Center (SCC) account](https://scc.suse.com/), fill the in the credentials in the `cc_username` and `cc_password` variables in the `base` module
- alternatively, if you don't have an SCC account, you may need to update source repositories under [sumaform/salt/repos](https://github.com/uyuni-project/sumaform/tree/master/salt/repos) depending on what VMs you want to provision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this part out. If one does not have SCC credentials, at this point it is just not possible to provision SLE based VMs, while openSUSE or other freely available distros will work fine.

Or what did you have in mind exactly with this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how users outside the organization may use the tool, so I wanted to cover both cases just to be sure based on the discussions I had with Dario. If you think the second line doesn't have practical value, I'll remove that bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove it for now

- make sure that:
- either your target libvirt host has a storage pool named `default`
- or you [create one](https://documentation.suse.com/sles/12-SP4/html/SLES-all/cha-libvirt-storage.html#sec-libvirt-storage-vmm-addpool)
Expand Down