Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect synchronization in private server #739

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Fix incorrect synchronization in private server #739

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5731e54
Fix incorrect synchronization in private server
pavelkumbrasev Jan 19, 2022
a22919b
Remove sleeping state. Add mutex synchronization
pavelkumbrasev Jan 26, 2022
693aa13
Remove mutex. Correct load memory order
pavelkumbrasev Jan 26, 2022
60dc0dd
Add explaining comment
pavelkumbrasev Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tbb/private_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,9 @@ void private_worker::run() noexcept {
// Prepare to wait
my_thread_monitor.prepare_wait(c);
// Check/set the invariant for sleeping
if( my_state.load(std::memory_order_acquire)!=st_quit && my_server.try_insert_in_asleep_list(*this) ) {
// We need memory_order_seq_cst to enforce ordering with prepare_wait
// (note that a store in prepare_wait should be with memory_order_seq_cst as well)
if( my_state.load(std::memory_order_seq_cst)!=st_quit && my_server.try_insert_in_asleep_list(*this) ) {
pavelkumbrasev marked this conversation as resolved.
Show resolved Hide resolved
my_thread_monitor.commit_wait(c);
__TBB_ASSERT( my_state==st_quit || !my_next, "Thread monitor missed a spurious wakeup?" );
my_server.propagate_chain_reaction();
Expand Down