Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create j-michelle-hu.yaml #40

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Create j-michelle-hu.yaml #40

merged 2 commits into from
Jun 20, 2024

Conversation

jmichellehu
Copy link
Contributor

No description provided.

@jmichellehu jmichellehu added the preview Trigger preview of website via PR label Jun 18, 2024
@jmichellehu jmichellehu requested a review from jomey June 18, 2024 20:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-40--event-page-2024.netlify.app

@JessicaS11
Copy link
Contributor

@jmichellehu I'm not sure what's going on (since it's building successfully), but when I click the link to your bio in the preview nothing happens. Can someone check if this is a general issue or only on my end?

@jomey
Copy link
Contributor

jomey commented Jun 18, 2024

@jmichellehu I'm not sure what's going on (since it's building successfully), but when I click the link to your bio in the preview nothing happens. Can someone check if this is a general issue or only on my end?

Only a quick guess, but the . in the first name might throw a wrench for opening the modal.

@jomey
Copy link
Contributor

jomey commented Jun 18, 2024

@jmichellehu I'm not sure what's going on (since it's building successfully), but when I click the link to your bio in the preview nothing happens. Can someone check if this is a general issue or only on my end?

Only a quick guess, but the . in the first name might throw a wrench for opening the modal.

Confirmed. Have to add support in the website logic and improve the handling of names with a .

jomey
jomey reviewed Jun 19, 2024
View reviewed changes
team/j-michelle-hu.yaml Outdated
link: https://www.linkedin.com/in/j-michelle-hu
user_groups:
# From https://escience.washington.edu/using-data-science/hackweeks/planning/hackweek-roles
- Hackweek helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency - I think we have all roles capitalized

Hackweek Helper

@jomey jomey mentioned this pull request Jun 19, 2024
Merged
@jmichellehu jmichellehu merged commit b008a0e into main Jun 20, 2024
1 check passed
@jmichellehu jmichellehu deleted the jmichellehu-patch-1 branch June 20, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomey jomey jomey approved these changes

Assignees
No one assigned
Labels
preview Trigger preview of website via PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmichellehu @JessicaS11 @jomey