Hapi 7.0.3 #2
Merged
Hapi 7.0.3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ivan-c
requested changes
Jun 5, 2024
| environment: | ||
| SPRING_CONFIG_LOCATION: file:///opt/application.yaml | ||
| spring.datasource.url: jdbc:postgresql://db:5432/hapifhir | ||
| spring.datasource.username: postgres | ||
| spring.datasource.password: postgres | ||
| spring.datasource.driverClassName: org.postgresql.Driver | ||
| spring.jpa.hibernate.dialect: org.hibernate.dialect.PostgreSQL94Dialect | ||
| spring.jpa.properties.hibernate.dialect: ca.uhn.fhir.jpa.model.dialect.HapiFhirPostgres94Dialect | ||
|
|
There was a problem hiding this comment.
I'd suggest configuring any overrides to the default application.yaml as environment variables (and use the vanilla application.yaml from Hapi)
Since env vars take precedence over values in application.yaml, it may not be obvious later which config is actually being used. It'll also be fewer changes to maintain when Hapi is upgraded in the future.
In the past, Hapi has required a application.yaml, but ideally we'd remove that in the future (since it's all defaults anyway)
Suggested change
| # enable IPS; use latest version | |
| hapi.fhir.ips_enabled: "true" | |
| hapi.fhir.implementationguides.ips_1_1_0.packageUrl: https://build.fhir.org/ig/HL7/fhir-ips/package.tgz | |
| hapi.fhir.implementationguides.ips_1_1_0.name: hl7.fhir.uv.ips | |
| hapi.fhir.implementationguides.ips_1_1_0.version: 1.1.0 | |
| # IPS needs this for $REASON | |
| hapi.fhir.allow_external_references: "true" | |
| hapi.fhir.enforce_referential_integrity_on_write: "false" | |
| hapi.fhir.auto_create_placeholder_reference_targets: "true" | |
| hapi.fhir.cr_enabled: "true" |
(I tested the above values via /actuator/configprops to confirm they work)
Co-authored-by: Ivan Cvitkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to HAPI version 7.0.3 with improvements to $summary support