Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakshya/f24/forgot password flow #43

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Conversation

laks0407
Copy link
Contributor

@laks0407 laks0407 commented Oct 25, 2024

f24/forgot-password-flow

Forgot Password Flow (Frontend)

Implementation description

  • Created frontend for Forgot Password page with custom breakpoints for different views
    (mobile, tablet, laptop, & monitor).Screenshot 2024-10-24 at 8 23 21 PM

  • The page will take a humane society email only, and if an invalid email is input, an error message will be shown.

Screenshot 2024-10-24 at 8 26 52 PM
  • If a valid email is inputted and a password reset HAS NOT already been sent, a success message will be shown.
Screenshot 2024-10-24 at 8 31 57 PM
  • If a valid email is inputted and a password reset HAS been sent, a warning message will be shown, which will disappear automatically after 60 seconds. The email will also be removed from localStorage after 60 seconds.
Screenshot 2024-10-24 at 8 37 29 PM

Steps to test

  1. Route to local/forgotPassword
  2. Test 1: Input a random invalid email
  3. Test 2: Input a valid email that follows %@humanesociety.org
  4. Test 3 : Input that same email again and try to send another request

What should reviewers focus on?

  • Any functionality that's missing (for ex: a UI timer to show when a user can send a request to the same email again was in the works but it's a little complex so I tabled it for now to get the frontend out)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jerry-cheng5 jerry-cheng5 removed the request for review from trinity-y October 29, 2024 23:05
@jerry-cheng5 jerry-cheng5 requested a review from vips11 November 5, 2024 00:27
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid!

just some minor details to fix.

frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/ForgotPassword.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/ForgotPassword.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! feel free to merge

@laks0407 laks0407 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit dc09e33 Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants