Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed activity to activity type #38

Merged
merged 2 commits into from
Oct 10, 2024
Merged

changed activity to activity type #38

merged 2 commits into from
Oct 10, 2024

Conversation

jerry-cheng5
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 commented Oct 9, 2024 •
edited
Loading

Notion ticket link

Notion Ticket

Implementation description

  • Changed all occurrences of activity to activityType

Steps to test

  1. Make sure migration up and down both work
  2. Make sure all the endpoints still work

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jerry-cheng5 jerry-cheng5 requested a review from sthuray October 9, 2024 03:31
sthuray
sthuray approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@sthuray sthuray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested node migrate up/down and they work as expected.

@jerry-cheng5 jerry-cheng5 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit ff1a9b7 Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthuray sthuray sthuray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerry-cheng5 @sthuray