Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F24/justin/add user management and admin pages #36

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

JustinScitech
Copy link
Contributor

@JustinScitech JustinScitech commented Oct 4, 2024

Notion ticket link

Ticket Name

Implementation description

  • Created a skeleton user management page that only admins and behaviourists can access. This can be found at the following route: admin/users

Steps to test

  1. Just test using roles as an admin or behavourist if you can go to the route: /admin/users

What should reviewers focus on?

  • Just focus on accessing using the different roles

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@JustinScitech JustinScitech changed the title Add user management and admin pages F24/justin/Add user management and admin pages Oct 8, 2024
@JustinScitech JustinScitech changed the title F24/justin/Add user management and admin pages F24/justin/add user management and admin pages Oct 8, 2024
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the most part, please keep the admin page. It may be converted into an admin dashboard in the future!

frontend/src/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JustinScitech JustinScitech added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 8a5fd21 Oct 9, 2024
1 check passed
@JustinScitech JustinScitech deleted the F24/Justin/User-Management-Page-Skeleton branch October 10, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants