Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed/repo cleanup #76

Merged
merged 5 commits into from
Mar 15, 2025
Merged

Ed/repo cleanup #76

merged 5 commits into from
Mar 15, 2025

Conversation

edouas
Copy link
Collaborator

@edouas edouas commented Mar 14, 2025

This PR includes:

  • Updated backend exception handling.
  • Added response and settings models.
  • Linted and formatted the connectors.

@voglerdaniel
Copy link
Collaborator

voglerdaniel commented Mar 15, 2025

Hey @edouas,

I checked out this branch to test it before merging, and unfortunately ran into an error:

image

Here's what I did to get to this error:

  • turned VPN on, ran docker
  • ran deploy/build.sh as usual
  • credentials wizard asked me to provide base urls for autofill and LLM backends. Since I don't have these, I provided empty values:
image

My expectation was that the Autofiller would still work normally. Unfortunately, the app crashes.

I'll look into the changes you made to try to understand why this is happening.

Question in the meantime – what's the intent behind allowing a URL for the Autofill backend? I can see why we need to provide a users for the LLM backend, since this is a separate endpoint, but not sure why we need it for autofill. Is this just adding flexibility for a possible future redesign?

@voglerdaniel
Copy link
Collaborator

Resolved – to get this to work, users should set

AUTOFILL_API_BASE_URL='http://backend:8000' (no forward slash at the end)

Merging this, then updating readme with instructions for the credentials wizard

@voglerdaniel voglerdaniel merged commit 6828a0a into main Mar 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants