Second commit for crc32 #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bafran
reviewed
Oct 28, 2024
libraries/ms-common/src/arm/crc32.c
Outdated
| @@ -0,0 +1,29 @@ | |||
| #include "crc32.h" // Include the header file for CRC32 function declarations | |||
|
|
|||
| #include "log.h" // Include the logging utility, possibly used for debugging or status messages | |||
There was a problem hiding this comment.
Closing out for now, please let us know if it should get merged
libraries/ms-common/src/arm/crc32.c
Outdated
| return STATUS_CODE_OK; // Return OK status | ||
| } | ||
|
|
||
| // Function to calculate CRC32 for a given buffer, with an option to append to an existing CRC |
There was a problem hiding this comment.
Is there an option to append an existing CRC? If so, please explain in this comment what parameter does that and how a user might do this
| CRC_CalcCRC(buffer[i]); // Calculate CRC for each byte | ||
| } | ||
|
|
||
| return ~CRC_GetCRC(); // Return the inverted final CRC value |
There was a problem hiding this comment.
Can you change this comment to explain why it's being inverted
libraries/ms-common/src/x86/crc32.c
Outdated
| @@ -0,0 +1,41 @@ | |||
| #include "crc32.h" // Include the header file for CRC32 function declarations | |||
|
|
|||
| #include "log.h" // Include the logging utility, possibly used for debugging or status messages | |||
There was a problem hiding this comment.
Same thing with comments here, can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.